Skip to content

Commit

Permalink
Refactor general feedback loops to separate test file.
Browse files Browse the repository at this point in the history
  • Loading branch information
kzaher committed Jan 30, 2019
1 parent f0abcb1 commit 1b152d6
Show file tree
Hide file tree
Showing 7 changed files with 394 additions and 496 deletions.
121 changes: 0 additions & 121 deletions Examples/Examples.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
objects = {

/* Begin PBXBuildFile section */
52D6D9871BEFF229002C0205 /* RxFeedback.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 52D6D97C1BEFF229002C0205 /* RxFeedback.framework */; };
C80987441EC4882E00EE2C23 /* Todo.swift in Sources */ = {isa = PBXBuildFile; fileRef = C80987431EC4882E00EE2C23 /* Todo.swift */; };
C80987621EC4A28300EE2C23 /* Todo+Plumbing.swift in Sources */ = {isa = PBXBuildFile; fileRef = C809875E1EC49F7400EE2C23 /* Todo+Plumbing.swift */; };
C80987631EC4A28E00EE2C23 /* Todo+Lenses.swift in Sources */ = {isa = PBXBuildFile; fileRef = C809875C1EC49F4900EE2C23 /* Todo+Lenses.swift */; };
Expand Down Expand Up @@ -155,27 +154,6 @@
remoteGlobalIDString = 52D6D97B1BEFF229002C0205;
remoteInfo = "RxFeedback-iOS";
};
C8996C701F40AA49004E5D83 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 52D6D9731BEFF229002C0205 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 52D6D97B1BEFF229002C0205;
remoteInfo = RxFeedback;
};
C8996C751F40AD55004E5D83 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = C834A8881EB67A8A00E6B15E /* Rx.xcodeproj */;
proxyType = 1;
remoteGlobalIDString = C8093B4B1B8A71F00088E94D;
remoteInfo = "RxBlocking-iOS";
};
E11E0E1F1F7674530031D189 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = C834A8881EB67A8A00E6B15E /* Rx.xcodeproj */;
proxyType = 1;
remoteGlobalIDString = C88FA4FD1C25C44800CCFEA4;
remoteInfo = "RxTest-iOS";
};
/* End PBXContainerItemProxy section */

/* Begin PBXCopyFilesBuildPhase section */
Expand All @@ -196,7 +174,6 @@

/* Begin PBXFileReference section */
52D6D97C1BEFF229002C0205 /* RxFeedback.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = RxFeedback.framework; sourceTree = BUILT_PRODUCTS_DIR; };
52D6D9861BEFF229002C0205 /* RxFeedbackTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = RxFeedbackTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
C80987431EC4882E00EE2C23 /* Todo.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Todo.swift; sourceTree = "<group>"; };
C80987581EC4916000EE2C23 /* Todo+Feedback.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "Todo+Feedback.swift"; sourceTree = "<group>"; };
C809875C1EC49F4900EE2C23 /* Todo+Lenses.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "Todo+Lenses.swift"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -237,14 +214,6 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
52D6D9831BEFF229002C0205 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
52D6D9871BEFF229002C0205 /* RxFeedback.framework in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
C834A8731EB679FB00E6B15E /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -274,7 +243,6 @@
isa = PBXGroup;
children = (
52D6D97C1BEFF229002C0205 /* RxFeedback.framework */,
52D6D9861BEFF229002C0205 /* RxFeedbackTests.xctest */,
C834A8761EB679FB00E6B15E /* Example.app */,
);
name = Products;
Expand Down Expand Up @@ -413,26 +381,6 @@
productReference = 52D6D97C1BEFF229002C0205 /* RxFeedback.framework */;
productType = "com.apple.product-type.framework";
};
52D6D9851BEFF229002C0205 /* RxFeedbackTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 52D6D9931BEFF229002C0205 /* Build configuration list for PBXNativeTarget "RxFeedbackTests" */;
buildPhases = (
52D6D9821BEFF229002C0205 /* Sources */,
52D6D9831BEFF229002C0205 /* Frameworks */,
52D6D9841BEFF229002C0205 /* Resources */,
);
buildRules = (
);
dependencies = (
E11E0E201F7674530031D189 /* PBXTargetDependency */,
C8996C761F40AD55004E5D83 /* PBXTargetDependency */,
C8996C711F40AA49004E5D83 /* PBXTargetDependency */,
);
name = RxFeedbackTests;
productName = RxFeedbackTests;
productReference = 52D6D9861BEFF229002C0205 /* RxFeedbackTests.xctest */;
productType = "com.apple.product-type.bundle.unit-test";
};
C834A8751EB679FB00E6B15E /* Example */ = {
isa = PBXNativeTarget;
buildConfigurationList = C834A8851EB679FB00E6B15E /* Build configuration list for PBXNativeTarget "Example" */;
Expand Down Expand Up @@ -469,10 +417,6 @@
DevelopmentTeam = 783T66X79Y;
LastSwiftMigration = 0820;
};
52D6D9851BEFF229002C0205 = {
CreatedOnToolsVersion = 7.1;
LastSwiftMigration = 0800;
};
C834A8751EB679FB00E6B15E = {
CreatedOnToolsVersion = 8.2.1;
ProvisioningStyle = Manual;
Expand Down Expand Up @@ -504,7 +448,6 @@
projectRoot = "";
targets = (
52D6D97B1BEFF229002C0205 /* RxFeedback */,
52D6D9851BEFF229002C0205 /* RxFeedbackTests */,
C834A8751EB679FB00E6B15E /* Example */,
C83B7CCE1EB7BCE5003055E0 /* Dependencies */,
);
Expand Down Expand Up @@ -594,13 +537,6 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
52D6D9841BEFF229002C0205 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
C834A8741EB679FB00E6B15E /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -642,13 +578,6 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
52D6D9821BEFF229002C0205 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
C834A8721EB679FB00E6B15E /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -707,21 +636,6 @@
target = 52D6D97B1BEFF229002C0205 /* RxFeedback */;
targetProxy = C888B5551EB67EB000FA27B0 /* PBXContainerItemProxy */;
};
C8996C711F40AA49004E5D83 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 52D6D97B1BEFF229002C0205 /* RxFeedback */;
targetProxy = C8996C701F40AA49004E5D83 /* PBXContainerItemProxy */;
};
C8996C761F40AD55004E5D83 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
name = "RxBlocking-iOS";
targetProxy = C8996C751F40AD55004E5D83 /* PBXContainerItemProxy */;
};
E11E0E201F7674530031D189 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
name = "RxTest-iOS";
targetProxy = E11E0E1F1F7674530031D189 /* PBXContainerItemProxy */;
};
/* End PBXTargetDependency section */

/* Begin PBXVariantGroup section */
Expand Down Expand Up @@ -911,32 +825,6 @@
};
name = Release;
};
52D6D9941BEFF229002C0205 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CLANG_ENABLE_MODULES = YES;
INFOPLIST_FILE = Tests/RxFeedbackTests/RxFeedbackTests.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks @executable_path/../Frameworks @loader_path/../Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "com.RxFeedback.RxFeedback-iOS-Tests";
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
};
name = Debug;
};
52D6D9951BEFF229002C0205 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CLANG_ENABLE_MODULES = YES;
INFOPLIST_FILE = Tests/RxFeedbackTests/RxFeedbackTests.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks @executable_path/../Frameworks @loader_path/../Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "com.RxFeedback.RxFeedback-iOS-Tests";
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
};
name = Release;
};
C834A8861EB679FB00E6B15E /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
Expand Down Expand Up @@ -1029,15 +917,6 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
52D6D9931BEFF229002C0205 /* Build configuration list for PBXNativeTarget "RxFeedbackTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
52D6D9941BEFF229002C0205 /* Debug */,
52D6D9951BEFF229002C0205 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
C834A8851EB679FB00E6B15E /* Build configuration list for PBXNativeTarget "Example" */ = {
isa = XCConfigurationList;
buildConfigurations = (
Expand Down
4 changes: 4 additions & 0 deletions RxFeedback.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
objects = {

/* Begin PBXBuildFile section */
1E2F2DE02201DCFF00DEEE9C /* ReactWithLatestTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1E2F2DDF2201DCFF00DEEE9C /* ReactWithLatestTests.swift */; };
52D6D9871BEFF229002C0205 /* RxFeedback.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 52D6D97C1BEFF229002C0205 /* RxFeedback.framework */; };
C834A8691EB6795F00E6B15E /* ObservableType+RxFeedback.swift in Sources */ = {isa = PBXBuildFile; fileRef = C834A8681EB6795F00E6B15E /* ObservableType+RxFeedback.swift */; };
C83596441FB22EE900DC7B8F /* ReactEquatableLoopsTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = C83596431FB22EE900DC7B8F /* ReactEquatableLoopsTests.swift */; };
Expand All @@ -33,6 +34,7 @@
/* End PBXContainerItemProxy section */

/* Begin PBXFileReference section */
1E2F2DDF2201DCFF00DEEE9C /* ReactWithLatestTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReactWithLatestTests.swift; sourceTree = "<group>"; };
52D6D97C1BEFF229002C0205 /* RxFeedback.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = RxFeedback.framework; sourceTree = BUILT_PRODUCTS_DIR; };
52D6D9861BEFF229002C0205 /* RxFeedbackTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = RxFeedbackTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
C8047ABB1F41099F0089721B /* CHANGELOG.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; path = CHANGELOG.md; sourceTree = "<group>"; };
Expand Down Expand Up @@ -191,6 +193,7 @@
C8996C7B1F40D82A004E5D83 /* String+Test.swift */,
C83596431FB22EE900DC7B8F /* ReactEquatableLoopsTests.swift */,
C83596451FB2312D00DC7B8F /* ReactHashableLoopsTests.swift */,
1E2F2DDF2201DCFF00DEEE9C /* ReactWithLatestTests.swift */,
C83596471FB24CAF00DC7B8F /* RxTest.swift */,
);
path = RxFeedbackTests;
Expand Down Expand Up @@ -322,6 +325,7 @@
C83596481FB24CAF00DC7B8F /* RxTest.swift in Sources */,
C8996C6B1F40A7A0004E5D83 /* RxFeedbackDriverTests.swift in Sources */,
C8996C6D1F40A7C1004E5D83 /* RxFeedbackObservableTests.swift in Sources */,
1E2F2DE02201DCFF00DEEE9C /* ReactWithLatestTests.swift in Sources */,
C8996C7C1F40D82A004E5D83 /* String+Test.swift in Sources */,
C83596461FB2312D00DC7B8F /* ReactHashableLoopsTests.swift in Sources */,
);
Expand Down
3 changes: 1 addition & 2 deletions Tests/RxFeedbackTests/ReactEquatableLoopsTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import RxFeedback
import RxSwift
import RxTest

class ReactEquatableLoopsTests: RxTest {
}
class ReactEquatableLoopsTests: RxTest {}

// Tests on the react function with not an equatable or hashable Control.
extension ReactEquatableLoopsTests {
Expand Down
3 changes: 1 addition & 2 deletions Tests/RxFeedbackTests/ReactHashableLoopsTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import RxFeedback
import RxSwift
import RxTest

class ReactHashableLoopsTests: RxTest {
}
class ReactHashableLoopsTests: RxTest {}

// Tests on the react function with not an equatable or hashable Control.
extension ReactHashableLoopsTests {
Expand Down
Loading

0 comments on commit 1b152d6

Please sign in to comment.