Add atomic FFI batches and shared read-only opens - #48
Merged
Conversation
added 2 commits
August 10, 2026 17:41
HoltFS needs one WAL record for partition data and manifest updates. Validate the complete C input array before building the Rust batch.
DuckDB workers need concurrent readers without granting recovery or checkpoint writes. Replay WAL state in memory, preserve torn tails, and reject mutations at both API and file-store boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuckDB HoltFS needs one C ABI call for atomic put/delete batches and a non-mutating way to inspect an existing Holt store.
holt_tree_atomicvalidates the complete operation array before it callsTree::atomic.holt_tree_open_read_onlyrequires an existing file-backed tree, holds a shared process lock, replays the WAL in memory, and leaves torn manifest and WAL tails unchanged. Read-only handles reject mutations and maintenance. Writers retain exclusive locks.This port starts from Holt 0.8.4 and preserves its
assert_absentguards and oversized WAL preflight.Validation:
cargo test --workspace --all-features --lib --tests --examples --locked(675 passed, 7 ignored)cargo test --workspace --all-features --doc --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningsholt-ffibuild and C ABI smoke test