refactor: remove NofxOS API key — all data requests now route through claw402

[deanokk]

Summary

Remove the hardcoded NofxOS API key (cm_568c67eae410d912c54c) and all associated configuration fields, validation, UI, and translations. NofxOS data service no longer requires an API key — all requests are now routed through the claw402 x402 payment gateway.

Changes

Backend:

• store/strategy.go: Remove NofxOSAPIKey field from IndicatorConfig and its default value from GetDefaultStrategyConfig()
• provider/nofxos/client.go: Remove DefaultAuthKey constant, fallback logic in NewClient(), and key from DefaultClient()
• kernel/engine.go: Simplify client creation — pass empty auth key since claw402 handles routing
• api/strategy.go: Remove API key validation from validateStrategyConfig()
• api/server.go: Remove indicators.nofxos_api_key from the AI prompt guide

Frontend:

• web/src/types/strategy.ts: Remove nofxos_api_key from IndicatorConfig type
• web/src/components/strategy/IndicatorEditor.tsx: Remove API key constant, status badges, warning, and unused imports
• web/src/i18n/strategy-translations.ts: Remove unused translation keys (apiKey, connected, notConfigured, configureApiKey, etc.)

Test plan

• go build ./... — no compilation errors
• go vet ./... — no issues
• npm run build — clean build
• npm run lint — no new warnings in changed files

[github-actions]

🤖 Advisory Check Results

These are advisory checks to help improve code quality. They won't block your PR from being merged.

📋 PR Information

Title Format: ✅ Good - Follows Conventional Commits
PR Size: 🔴 Large (1131 lines: +788 -343)

💡 Suggestion: This is a large PR. Consider breaking it into smaller, focused PRs for easier review.

🔧 Backend Checks

Go Formatting: ⚠️ Needs formatting

Files needing formatting

agent/brain.go
agent/execution_state.go
agent/onboard.go
agent/planner_runtime.go
agent/scheduler.go
agent/sentinel.go
agent/skill_dag.go
agent/skill_dag_runtime.go
agent/skill_execution_handlers.go
agent/stock.go

Go Vet: ✅ Good
Tests: ✅ Passed

Fix locally:

go fmt ./...      # Format code
go vet ./...      # Check for issues
go test ./...     # Run tests

⚛️ Frontend Checks

Build & Type Check: ✅ Success

Fix locally:

cd web
npm run build  # Test build (includes type checking)

---

📖 Resources

• Contributing Guidelines
• Migration Guide

Questions? Feel free to ask in the comments! 🙏

---

These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml.