-
Notifications
You must be signed in to change notification settings - Fork 91
migrate tests from nbs to pytest #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@elephaint I can't reproduce this error locally |
@deven367 I can reproduce this locally using my mac platform. Will post here if I have new findings |
@deven367
The main reason is that the UtW computed can differ slightly for Mac OSvs Ubuntu platform and this results in the instability for np.linalg.solve(), despite using the same numpy version 2.2.6
|
across different platform runs
Checking out the commits did fix the CI issues |
JQGoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some comments to consider for improvements and a few questions to clarify. After your revision, I suggest that we can invite @elephaint to have a second look.
elephaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Few (minor) comments:
- I think wherever possible we should use Narwhals, avoiding the need for any pandas vs polars control flow
- Wherever .reconcile is called,
Sargument should beS_dfto avoid getting deprecation messages.
@elephaint It's fixed now! |
|
The recent release of Hence the version is now being pinned to |
elephaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

This PR tries to finish the first step in removing
nbdevfrom the library. Tests from thecoremodule have not been converted to pytest yet.Edit: The tests from the
coremodule have also been converted.