Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MSSE into RelMSE, add new implementation of MSSE #185

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Rename MSSE into RelMSE, add new implementation of MSSE #185

merged 4 commits into from
Apr 19, 2023

Conversation

nickto
Copy link
Contributor

@nickto nickto commented Apr 19, 2023

Following the discussion in #184:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nickto nickto mentioned this pull request Apr 19, 2023
Closed
@kdgutier kdgutier self-requested a review April 19, 2023 11:11
@kdgutier kdgutier linked an issue Apr 19, 2023 that may be closed by this pull request
MSSE definition incosistent with Hyndman and Koehler 2005 #184
Closed
kdgutier
kdgutier reviewed Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@kdgutier kdgutier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool @nickto,

Thanks for adding the msse and renaming mse into rel_mse.
I added some comments regarding the documentation and msse reference.

hierarchicalforecast/evaluation.py Outdated Show resolved Hide resolved
hierarchicalforecast/evaluation.py Outdated Show resolved Hide resolved
@kdgutier kdgutier merged commit 1432202 into Nixtla:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdgutier kdgutier kdgutier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSSE definition incosistent with Hyndman and Koehler 2005
3 participants
@nickto @CLAassistant @kdgutier