[FEAT] Core Numeric Type and Null Protections #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kdgutier
reviewed
Apr 17, 2023
There was a problem hiding this comment.
Thanks for the contribution.
- Can you add a
test_failunit test simulating the expected behavior of the protection? For a reference check the example on "different series S and Y_hat_df" in the samenbs/core.ipynbnotebook. - Let's add a Null protection to the target variable too.
kdgutier
changed the title
kdgutier
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Y_hat_df is passed into HierarchicalForecast.reconcile() without numeric types, it leads to a silent bug where the reconcile takes extremely long and then throws an error.
I added a type check in the .reconcile (core.ipynb) which throws an exception if the Y_hat_df does not have numeric types
I also added a NaN/None check in the .reconcile (core.ipynb) which throws an exception if the Y_hat_df has null values
I also added a NaN/None check in the aggregate function (utils.ipynb) which throws an exception if the Y_hat_df has null values