Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate and de-duplicate local-test make targets #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blu-nitro
Copy link
Member

As described in #2 this simplifies local test make targets.

@blu-nitro blu-nitro mentioned this pull request Jul 15, 2024
6 tasks
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One additional request: Sometimes the development device is in a state where it is not recognized by nitropy nk3 status. Nevertheless I’d like to be able to trigger the test. So can you please add a target without the auto-detection where I can set MODEL to select the model?

@blu-nitro
Copy link
Member Author

Sometimes the development device is in a state where it is not recognized by nitropy nk3 status. Nevertheless I’d like to be able to trigger the test. So can you please add a target without the auto-detection where I can set MODEL to select the model?

Now it detects whether you manually set the MODEL and if so it skips the automatic detection all in the same target. All this conditional execution is not very nice in make, but it works. We could also just have two separate make targets as you described, but i thought this way was simpler from user perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants