lpc55: Improve IFS and PRINCE setup #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
requested review from
daringer,
szszszsz and
sosthene-nitrokey
Previously, we enabled the complete PRINCE region 2 if we wanted to access the FS. This means that we also tried to encrypt parts of the firmware if was written after 0x80_000 (start of region 2) although the firmware is not encrypted. With this patch, we only enable the PRINCE subregions that actually contain the filesystem. This requires extracting the filesystem definition from the lpc55-hal crate.
As we can only enable or disable the PRINCE hardware encryption in subregions of 8 KiB starting from 0x80_0000 and the (encrypted) filesystem starts at 0x93_0000, we can only use the flash up to 0x92_000 for firmware. (Otherwise the firmware would become unreadable if we decrypt the filesystem subregion.)
For the lpc55 profile, the filesystem end config value was incorrect. This did not have any effect, but for consistency, we correct it and also change the InternalStore implementation to use this config value for the FS setup.
Instead of truncating the flash and filesystem sizes to multiples of 1024, we now use the exact values. This is necessary as the FS size on the lpc55 is 43.5 KiB.
robin-nitrokey
force-pushed
the
ifs-prince
branch
from
a8fc983
to
b0477fc
Compare
|
lgtm, especially having the read/write/erase primitives inside the runner introduces more consistency between lpc55 & nrf52 - otherwise introducing this into the |
daringer
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several patches that improve the IFS and PRINCE setup:
Limitation: Currently, our build script truncates the length of the IFS to multiples of 1024 when generating the linker script. I think this should not be an issue as the filesystem region defined in the linker script does not have any effects AFAIK, but we could fix this by writing the full values instead.Fixed by using the full values.