-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork ctap-types #180
Fork ctap-types #180
Conversation
This patch replaces upstream ctap-types with a fork that improves compatibility when deserializing COSE keys.
In my tests, this fixes the |
Does not seem to fix the fido2luks problem per se, but looks better than the last time:
(done with usbip sim, using Makefile from the linked #177 ticket) self.state.runtime.active_get_assertion = Some(state::ActiveGetAssertionData {
rp_id_hash: {
let mut buf = [0u8; 32];
buf.copy_from_slice(&rp_id_hash);
buf
},
client_data_hash: {
let mut buf = [0u8; 32];
buf.copy_from_slice(¶meters.client_data_hash); // <---
buf
},
uv_performed,
up_performed,
multiple_credentials,
extensions: parameters.extensions.clone(),
}); Whole log: click to show
|
This means we receive an empty |
This patch replaces upstream ctap-types with a fork that improves compatibility when deserializing COSE keys.