Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin-app: UUID command not available over CTAPHID #8

Closed
robin-nitrokey opened this issue Oct 18, 2021 · 3 comments · Fixed by #10
Closed

admin-app: UUID command not available over CTAPHID #8

robin-nitrokey opened this issue Oct 18, 2021 · 3 comments · Fixed by #10
Assignees
@robin-nitrokey
Labels
bug Something isn't working

Comments

@robin-nitrokey
Copy link
Member

The admin app’s UUID command is only available over CCCID, not CTAPHID.
@robin-nitrokey robin-nitrokey added the bug Something isn't working label Oct 18, 2021
@robin-nitrokey robin-nitrokey self-assigned this Oct 18, 2021
@robin-nitrokey robin-nitrokey changed the title admin: UUID command not available over CTAPHID admin-app: UUID command not available over CTAPHID Oct 18, 2021
@szszszsz
Copy link
Member

Should it be available overt CTAPHID?

@robin-nitrokey
Copy link
Member Author

It is listed as a supported command so I assumed the missing implementation was a bug. Is there a reason to not have it in the CTAPHID interface?

@szszszsz
Copy link
Member

Indeed, ideally all interfaces would allow accessing vendor's commands. This could allow to work with pynitrokey easily as well. The question is, whether we need that.

@robin-nitrokey robin-nitrokey mentioned this issue Oct 18, 2021
Merged
robin-nitrokey added a commit to robin-nitrokey/solo2 that referenced this issue Oct 18, 2021
@robin-nitrokey
Fix CTAPHID command dispatch for admin app
fb2bf7a 
Previously, the CTAPHID interface of the admin app did not handle the
UUID command and interpreted all unknown commands as Wink commands.
With this patch, we explicitly handle both the Wink and the UUID command
and return an error if any other command is received.

Fixes Nitrokey#8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robin-nitrokey robin-nitrokey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CTAPHID command dispatch for admin app robin-nitrokey/solo2
2 participants
@szszszsz @robin-nitrokey