Repository navigation
Consider enforcing a consistent coding style and naming convention #169
Description
Currently, the coding style in the C++ and C source code is often inconsistent (indentation, spacing, brace placement, …). Sometimes this makes it hard to read the code. Would you consider defining a consistent coding style and using a tool like clang-format to enforce it?
Also, most files use the cc extension, except DeviceCommunicationExceptions.cpp. Some files use camel case (NitrokeyManager.cc) and some only lower case (device.cc). Would you agree to a consistent naming scheme?
Activity
szszszsz commentedon Jan 13, 2020
Hi!
Of course! Sorry for that. I plan large refactoring/clean up (this/next month), including code reformat, which hopefully will decrease the confusion here.
Back then I was avoiding code whitespace reformat to keep the ability of clean patches revert, and easy to find sources of the changes. Now I plan to add a style check as a part of CI and git hooks, which would prevent such issues.
robinkrahl commentedon Jan 13, 2020
robinkrahl commentedon Mar 31, 2020
Do you have an update on this? I have some patches I’d like to submit, but I think it would be better to wait for the refactoring.
szszszsz commentedon Apr 2, 2020
Hi!
Sorry for the delay. Feel free to submit the patches, I will handle them on refactoring without a problem. I think this is best option, so I will not hold you back with the
nitroclidevelopment.Merge pull request Nitrokey#169 from Nitrokey/pin-black