Optimize stack usage of Dispatch::poll #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
take-response
branch
from
8140cad
to
506ee45
Compare
Dispatch::poll has to copy the request so that the app can write the response to the interchange. Previously, we called Responder::take_request to obtain the message out of the interchange. This implementation had a stack usage of 15280 bytes while the message size is only 7609 bytes. With this patch, we only request a reference from the responder and manually copy the message to a buffer. This reduces the stack size to 7664 bytes. I have no idea why the take_request implementation creates an additional copy of the message. But as this function is the root for all CTAPHID commands, this means we can save around 7 kB stack virtually everywhere. Similar optimizations may be possible in other functions too.
robin-nitrokey
force-pushed
the
take-response
branch
from
506ee45
to
7f08ac0
Compare
sosthene-nitrokey
approved these changes
Oct 6, 2023
daringer
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatch::pollhas to copy the request so that the app can write the response to the interchange. Previously, we calledResponder::take_requestto obtain the message out of the interchange. This implementation had a stack usage of 15280 bytes while the message size is only 7609 bytes.With this patch, we only request a reference from the responder and manually copy the message to a buffer. This reduces the stack size to 7664 bytes.
I have no idea why the
take_requestimplementation creates an additional copy of the message. But as this function is the root for all CTAPHID commands, this means we can save around 7 kB stack virtually everywhere. Similar optimizations may be possible in other functions too.