Skip to content

IllegalStateException on Error Dialog in Search Activity #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ninjaman494 merged 2 commits into from
Mar 7, 2021
Merged

IllegalStateException on Error Dialog in Search Activity #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bc91e1
Updated onBackPressed to finish
Ninjaman494 Mar 7, 2021
bc974d8
Fixed deprecation warning
Ninjaman494 Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/a494studios/koreanconjugator/conjugations/ConjugationActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void onDataReceived(List<List<ConjugationFragment>> conjugations) {
public void onError(Throwable e) {
e.printStackTrace();
Utils.handleError(e, ConjugationActivity.this,4,
(dialogInterface, i) -> ConjugationActivity.this.onBackPressed());
(dialogInterface, i) -> ConjugationActivity.this.finish());
}
});

Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/a494studios/koreanconjugator/conjugator/ConjugatorActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public void onError(Throwable e) {
e.printStackTrace();
AppCompatActivity activity = ConjugatorActivity.this;
Utils.handleError(e, activity,11,
(dialogInterface, i) -> activity.onBackPressed());
(dialogInterface, i) -> activity.finish());
}

@Override
Expand Down Expand Up @@ -183,7 +183,7 @@ public void onDataReceived(List<List<ConjugationFragment>> conjugations) {
public void onError(Throwable e) {
e.printStackTrace();
Utils.handleError(e, ConjugatorActivity.this,10,
(dialogInterface, i) -> ConjugatorActivity.this.onBackPressed());
(dialogInterface, i) -> ConjugatorActivity.this.finish());
}
});

Expand Down
6 changes: 3 additions & 3 deletions app/src/main/java/com/a494studios/koreanconjugator/display/DisplayActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ protected void onCreate(Bundle savedInstanceState) {
// Make sure extras were passed
if(id == null){
Exception exception = new Exception("ID was null in DisplayActivity");
Utils.handleError(exception, this, 5, (dialogInterface, i) -> onBackPressed());
Utils.handleError(exception, this, 5, (dialogInterface, i) -> finish());
return;
}

Expand All @@ -66,7 +66,7 @@ protected void onCreate(Bundle savedInstanceState) {
@Override
public void onError(Throwable t) {
t.printStackTrace();
Utils.handleError(t, DisplayActivity.this,2, (dialogInterface, i) -> DisplayActivity.this.onBackPressed());
Utils.handleError(t, DisplayActivity.this,2, (dialogInterface, i) -> DisplayActivity.this.finish());
}

@Override
Expand Down Expand Up @@ -111,7 +111,7 @@ public void onComplete() {
// If no conjugations, create an empty list to prevent a null exception
.map(o -> o instanceof String
? new FavoritesQuery.Data(new ArrayList<>())
: ((Response<FavoritesQuery.Data>) o).data())
: ((Response<FavoritesQuery.Data>) o).getData())
.subscribeWith(observer);

LinearLayout linearLayout = findViewById(R.id.disp_root);
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/a494studios/koreanconjugator/search/SearchActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void onNext(Response<SearchQuery.Data> dataResponse) {
@Override
public void onError(Throwable e) {
e.printStackTrace();
Utils.handleError(e, SearchActivity.this, 1, (dialogInterface, i) -> SearchActivity.this.onBackPressed());
Utils.handleError(e, SearchActivity.this, 1, (dialogInterface, i) -> SearchActivity.this.finish());
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/a494studios/koreanconjugator/search_results/SearchResultsActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ protected void onCreate(Bundle savedInstanceState) {
String query = getIntent().getStringExtra(EXTRA_QUERY);
if(query == null){ // Null check for extra
Exception exception = new Exception("Query was null in SearchResultsActivity");
Utils.handleError(exception, this, 6, (dialogInterface, i) -> onBackPressed());
Utils.handleError(exception, this, 6, (dialogInterface, i) -> finish());
return;
}

Expand Down Expand Up @@ -130,7 +130,7 @@ public void onNext(Response<SearchQuery.Data> dataResponse) {
@Override
public void onError(Throwable e) {
e.printStackTrace();
Utils.handleError(e, SearchResultsActivity.this, 3, (dialogInterface, i) -> SearchResultsActivity.this.onBackPressed());
Utils.handleError(e, SearchResultsActivity.this, 3, (dialogInterface, i) -> SearchResultsActivity.this.finish());
}

@Override
Expand Down