Skip to content

#45 #48 Fixes Favorites#49

Merged
Ninjaman494 merged 8 commits intomasterfrom
#45_and_#48
Dec 6, 2020
Merged

#45 #48 Fixes Favorites#49
Ninjaman494 merged 8 commits intomasterfrom
#45_and_#48

Conversation

@Ninjaman494
Copy link
Copy Markdown
Owner

Closes #45 and #48, both of which are related to favorites.

  • Added a null check in DisplayObserver to handle cases where a conjugation doesn't exist for a word (i.e. Determiner Past).
  • Used new favorites endpoint to implement honorific favorites
  • Implemented fragments in GraphQL queries to reduce code duplication
  • Updated tests to used json files for mock responses instead of ridiculously long JSON strings.
  • Display Activity test now tests for the Determiner Past edge case

@Ninjaman494 Ninjaman494 merged commit 5abbc31 into master Dec 6, 2020
@Ninjaman494 Ninjaman494 deleted the #45_and_#48 branch December 6, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Having Determiner Past as a favorite causes crashes on adjectives

1 participant