#34 WOD Card's button should be disabled while loading#37
Merged
Ninjaman494 merged 5 commits intomasterfrom Oct 10, 2020
Merged
#34 WOD Card's button should be disabled while loading#37Ninjaman494 merged 5 commits intomasterfrom
Ninjaman494 merged 5 commits intomasterfrom
Conversation
DisplayCardView is now passed down to the card bodies, who can use different setters to configure the button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34 . I modified how display cards modify their
DisplayCardView's button. TheDisplayCardViewis now passed down in theaddBodyViewmethod, and it has methods for disabling, hiding, and setting button text.WOD card uses this new functionality to disable the button before fetching, and then enables it once it gets a successful response.