feat: add async to nilrag and nildb call #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimouris
approved these changes
Apr 3, 2025
manel1874
force-pushed
the
feat/async-nilrag-nildb-call
branch
from
907f7a4 to
05ac8fe
Compare
1 task
jcabrero
reviewed
Apr 7, 2025
| # Step 3: Ask NilDB to compute the differences | ||
| logger.debug("Requesting computation from NilDB...") | ||
| difference_shares = nilDB.diff_query_execute(nilql_query_embedding) | ||
| difference_shares = await nilDB.diff_query_execute(nilql_query_embedding) |
Member
There was a problem hiding this comment.
Nit: Could we have type information for difference_shares?
It would mean adding something like: difference_shares: Dict[int, Dict[int, int]] if each entry contains an int id and the difference between each id and others. It improves readability.
jcabrero
approved these changes
Apr 7, 2025
Member
jcabrero
left a comment
jcabrero
left a comment
There was a problem hiding this comment.
👍
If you want to add the small nit on the other PR for the new types, I think that is fine. Just leaving it here for the record.
For the rest the PR looks good to me.
Member
|
The PR is failing because of the formatting. You can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds async call to nildb nodes when nilrag is executed.
It also adds:
num_chunks.