Skip to content

Conversation

@jcabrero
Copy link
Member

@jcabrero jcabrero commented Jul 2, 2025

This PR adds a new docker-compose.v2 yml that would enable connecting more API endpoints (with it's own unique configurations) to the backend models. This enables having a single GPU deployment being exploited by different endpoints, in this case, the production and test environments.

image

@jcabrero jcabrero requested a review from Copilot July 2, 2025 09:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an advanced Docker Compose configuration to support multiple API endpoints on a single GPU deployment, updates the Grafana dashboard identifiers, and provides separate compose files for production and development environments.

  • Updates Grafana dashboard JSON with a new datasource UID and an updated title for the NUC-specific dashboard
  • Refines network comments and adds explicit name fields in the main docker-compose.yml
  • Adds docker-compose.v2.yml for production endpoint deployment and docker-compose.v2.dev.yml for development endpoint deployment

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
grafana/runtime-data/dashboards/nuc-query-data.json Updated datasource UIDs and renamed dashboard title to include "NUC"
docker-compose.yml Enhanced root network comments and added name entries under networks
docker-compose.v2.yml New Compose file defining production endpoint services and networks
docker-compose.v2.dev.yml New Compose file for development endpoint; currently only API services
Comments suppressed due to low confidence (5)

docker-compose.yml:221

  • The backend_net network specifies a name but lacks external: true. Without marking it external, Compose will try to create it instead of attaching to the existing network. Please add external: true under backend_net.
    name: backend_net

docker-compose.yml:229

  • The proxy_net network has a name defined but is missing external: true. To ensure it attaches to the pre-existing proxy network, add external: true under proxy_net.
    name: proxy_net

docker-compose.v2.yml:1

  • [nitpick] Using #! for comments can be misleading (it resembles a shebang). Consider using a standard # prefix for all YAML comments to maintain consistency.
#!  This is a docker compose to deploy another endpoint for the nilai-api

docker-compose.v2.dev.yml:1

  • The header comment states that this file includes services for postgres, redis, prometheus, grafana, and node-exporter, but only api and nuc-api are defined. Please update the comment to reflect the actual services or add the missing definitions.
#!  This is used to deploy the nilai-api for the development environment

docker-compose.v2.dev.yml:5

  • The development Compose file lacks definitions for required services like postgres and redis, which will cause the APIs to fail on startup. Consider including or referencing these services as in the production setup.
services:

@jcabrero jcabrero marked this pull request as ready for review July 2, 2025 10:39
@jcabrero jcabrero requested a review from blefo July 2, 2025 10:39
@jcabrero jcabrero merged commit b533e8a into main Jul 9, 2025
5 checks passed
@jcabrero jcabrero deleted the chore/advanced_configuration branch July 31, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants