feat: encrypt & decrypt with seeds #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
self-assigned this
jimouris
approved these changes
Apr 2, 2025
|
@lapets merge in order, this is after the shamir. Also, preferably we can use "rebase and merge" instead of merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a method to create seeds instead of the regular store operation which creates secret shares. Default seed length is set to 64. In decrypt, it sorts the shares by length assuming they will either be all the same length, which means they will just be xored as before, or they will be different length, which means every share except the longest is a seed. This ensures backward compatibility as shares already uploaded would just be xored together.