Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Restart Sensor" when incompatible #3572

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Jul 16, 2024

This PR will disable Restart Sensor for devices that cannot be restarted.

Without this, an inexperienced user may enable the setting and when the time comes for the next sensor, it may take up to half an hour for their restart attempt to fail and be obvious that something may be wrong.

I have also seen a case where the failure would happen in just a few minutes, but it would attempt another restart.
The user had posted on facebook asking for help.
It took quite a while to realize that they had enabled restart sensor for a new G6.

I cannot think of any case that would be at a disadvantage after including this. Can you think of a scenario where this PR would disable restart sensor where it would actually be possible?

G5 and very old G6 devices are the only ones that can benefit from enabling restart sensor. This PR does not change that. They will still be able to enable, and use, restart.

@Navid200
Copy link
Collaborator Author

Navid200 commented Jul 16, 2024

Testing

I enabled restart sensor before this PR with the latest Nightly and it remained enabled for a G6.
I then used this PR and after 10 minutes, the setting was automatically disabled.

Unfortunately, I don't have a G5 or very old G6 to test.
But, we will know as reported by users under the unlikely event that this would cause any interference.

@jamorham
Copy link
Collaborator

I think this is okay but you might want to use a higher log level like ueh or wtf to ensure that the event is very visible in the logs. It should be a one time only thing and informing the user of a forced change so I think it is good to make it very obviousl

@Navid200
Copy link
Collaborator Author

Done!

@Navid200
Copy link
Collaborator Author

Navid200 commented Aug 9, 2024

I made the change you asked for.

@Navid200
Copy link
Collaborator Author

Thanks so much for the review.

I know that reviewing someone else's work is a boring job. The person who does the work enjoys the creativity aspect. The reviewer is looking at his/her work.

It is a hard, challenging and tiring work. Thanks for doing it.

@jamorham jamorham merged commit 655e802 into NightscoutFoundation:master Sep 27, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_07_16 branch September 27, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants