Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect G7 note to start sensor #3245

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

Navid200
Copy link
Collaborator

Right after first connectivity to a G7 device after transmitter days becomes known, xDrip shows the following note before full connectivity has been established:

Now start your sensor or check Settings

If xDrip knows transmitter days for a G7, it means that the sensor has already started. There is never a need to start a G7 sensor except for troubleshooting if xDrip fails to automatically start.
Under normal circumstances, you never need to tap on start sensor for a G7.

This PR continues to show the following note instead until full connectivity after which warmup period is shown.

Verify settings and wait for connectivity.

@jamorham
Copy link
Collaborator

As mentioned in another PR, I will expose shortTxId() so you can use that instead of repeating the logic.

@Navid200
Copy link
Collaborator Author

G6 will be verified before tomorrow.

@Navid200
Copy link
Collaborator Author

I will verify this in 4 days.

@Navid200 Navid200 marked this pull request as draft January 6, 2024 14:43
@Navid200 Navid200 marked this pull request as ready for review January 6, 2024 20:22
@Navid200
Copy link
Collaborator Author

Navid200 commented Jan 6, 2024

I have tested this now.
It does what it is supposed to. The correct note is shown on the main screen for G7.

@Navid200
Copy link
Collaborator Author

Navid200 commented Feb 4, 2024

I'm using shortTxId now. Is anything else missing in this?

Der-Schubi added a commit to Der-Schubi/xDrip that referenced this pull request Feb 8, 2024
Merge remote-tracking branch 'Navid200/Navid_2023_12_17' into schubi
@jamorham jamorham merged commit 10c2231 into NightscoutFoundation:master Feb 24, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2023_12_17 branch February 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants