-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix carelink login error 504 #3029
Conversation
@benceszasz can you review this thanks |
@ah7675 |
Here are tests I did:
Note. I didn't use carelink for months, just started few days ago for debugging. Yes, I do agree that maybe recent outage causes massive retries and eventually Carelink ban certain clients in my region. BTW, why do you think latest xdrip version may run without problem? I thought it's all the same for version after May. |
@ah7675 so after changing back to the official version you still get the HTTP 504 error? I do agree that changing the user agent could solve the banning issue, if that is the case. I am just trying to figure out why certain users gets this HTTP 504 error and trying to find a final solution for such cases, since this has happend during earlier CareLink server outages and the issue disappeared after some time. This seems to be the perfect time for testing, since there are users who have the 504 error. I recommended the current version, because it is easier to download. BTW the latest changes in the CareLink communication were in June, this is the minimum recommended version for CareLink Follower: |
Correct, all combinations are failed except the one which has 115 tag in user-agent.
I see. I'm also curious about the root cause.
Got it. But I think they are not relevant, since 504 error is returned by very first SSO endpoint. In addition, I just tried more combinations with regard to source ip & server ip & country_code.
All of above failed with 504. Therefore I think this is not region based issue.
It works as long as I change 'Chrome/112.0.0.0' to something else. |
This is very strange... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct update of Chrome user agent version to the latest one. This modification solves the issue of some users who gets an HTTP 504 error.
@jamorham |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that from what I see discussed that this should be merged.
xDrip carelink follow gets 504 error whereas Medtronic Carelink app and WebUI is working properly.