Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWEEP: Replace J2N's TripleShift call with C# 11's unsigned right shift operator #116

Merged
merged 1 commit into from
Nov 4, 2024
Merged

SWEEP: Replace J2N's TripleShift call with C# 11's unsigned right shift operator #116

merged 1 commit into from
Nov 4, 2024
+124 −149

Conversation

paulirwin
Copy link
Collaborator

Fixes #115

NightOwl888
NightOwl888 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Owner

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good!

src/J2N/Collections/BitSet.cs Show resolved Hide resolved
@paulirwin paulirwin merged commit bfe6442 into NightOwl888:main Nov 4, 2024
22 checks passed
@paulirwin paulirwin deleted the issue/115 branch November 4, 2024 15:44
@NightOwl888 NightOwl888 added the notes:performance-improvement Contains a performance improvement label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightOwl888 NightOwl888 NightOwl888 approved these changes

Assignees
No one assigned
Labels
notes:performance-improvement Contains a performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace J2N.Numerics.BitOperation.TripleShift with >>> in C# 11
2 participants
@paulirwin @NightOwl888