Converted Java array-style ref/out/return values into ref/out parameters in .NET (Fixes #57) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from array to ref int
… parameter from int[] to ref int (see #57)
…om int[] to ref int (see #57)
…ed fixed length state parameter to ref byte state0 and ref byte state1 (see #57)
…om int[] to ref int (see #57)
…arseSingleID() + ParseGlobalFilter()): Changed pos parameter from int[] to ref int (see #57)
…: Changed withParens parameter from int[] to ref int (see #57). Note that this could be cleaned up further (separate input and output parameters), but since it is in an internal type there is no need.
…Changed globalFilter parameter from UnicodeSet[] to out UnicodeSet (see #57)
…eter from int[] to ref int (see #57)
…meter from int[] to out int (see #57)
…CU4N.Text.Collator::GetFunctionalEquivalent(): Changed isAvailable parameter from bool[] to out bool (see #57)
…o parameter from bool[] to out bool. There is already an overload that allows omitting the inBlockZero parameter. See #57.
… int[] to out int (see #57).
…ring array parameter to out parameters for language, script, and region (see #57)
…g[] to out long (see #57)
…"fields" parameter from an int[] to individual out parameters for year, month, dayOfMonth, dayOfWeek, dayOfYear, and millisecondOfDay and changed return value to void
…t parameters and eliminated extra array member variable (see #57)
…s for all projects
…to out parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57.