Skip to content

Conversation

Copy link

Copilot AI commented Dec 5, 2025

Rebases NickCrews/pgai#898 onto current main, incorporating upstream changes from timescale#884 and timescale#901 (PostgreSQL 18 support).

Changes

  • Gemini provider support: Add gemini case with 250 max chunks per batch per Vertex AI quotas
  • Environment variable override: Introduce PGAI_MAX_CHUNKS_PER_BATCH to bypass provider-specific defaults
  • Improved fallback messaging: Display actual fallback value in warning for unknown providers

Enhancements over original PR

  • Type correctness: Convert env var from str to int (original returned string)
  • Input validation: Reject non-numeric or non-positive values with warnings
# Environment variable usage
export PGAI_MAX_CHUNKS_PER_BATCH=100

# Invalid values gracefully fall back to provider defaults
export PGAI_MAX_CHUNKS_PER_BATCH=-5    # Warning: must be positive
export PGAI_MAX_CHUNKS_PER_BATCH=abc   # Warning: must be valid integer

Co-authored-by: NickCrews 10820686+NickCrews@users.noreply.github.com

Original prompt

This section details on the original issue you should resolve

<issue_title>rebase timescale#898 (comment) on main</issue_title>
<issue_description>@copilot please rebase the patch-1 branch on top of the updated upstream main branch, as described in timescale#898 (comment)</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits December 5, 2025 07:01
… config

Co-authored-by: NickCrews <10820686+NickCrews@users.noreply.github.com>
Co-authored-by: NickCrews <10820686+NickCrews@users.noreply.github.com>
Copilot AI changed the title [WIP] Rebase patch-1 branch on updated main branch Rebase PR #898: Add gemini provider support and PGAI_MAX_CHUNKS_PER_BATCH env var Dec 5, 2025
Copilot AI requested a review from NickCrews December 5, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rebase https://github.com/timescale/pgai/pull/898#issuecomment-3613289850 on main

2 participants