Return generic auth error to prevent user enumeration attacks #4179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On invalid user/password error the error message "Invalid email or password" is returned. Thereby, no information about the existence of the user is given.
|
Since this fixes CWE-204: Observable Response Discrepancy, I look forward to this being merged relatively quick as it is only a minor change in the code base directly influencing the security of NPM |
|
Docker Image for build 1 is available on Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When authentication fails, the generic error message "Invalid email or password" is returned. Thereby, no information about the existence of the user is given.
This prevents user enumeration attacks because the response for both scenarios is identical.
Fixes #3873