Postgresql support #4086
Closed
Postgresql support #4086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docker/dev/Dockerfile
|
Docker Image for build 4 is available on Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes |
Closed
|
FYI I'm aware this exists and conflicts with #4087 but just need properly review both and decide on the best one. |
Merged
|
I've taken parts of this PR and merged it. Thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I did some more extensive testing and fixed any issues I encountered.
To circumvent the issues with json fields I decided to cast the fields as nvarchar since the syntax is similar in both Mysql and Postgresql. The functionality work similar when doing this on both Postgresql and Mysql.
It seems be working. However I haven't been able to test the certificates section yet. But the rest is working fine.
Let me know if what you guys think or if you have any comments on the changes.