Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of the ssl protocols/ciphers is done using the default sever block #189

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

jlesage
Copy link
Contributor

@jlesage jlesage commented Aug 20, 2019

The check for allowed SSL protocols is done before SNI, thus the default server block is always used.

See https://www.ruby-forum.com/t/ssl-protocols-per-server/232557/11

@jc21
Copy link
Member

jc21 commented Aug 20, 2019

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-189-amd64

@jc21
Copy link
Member

jc21 commented Aug 20, 2019

Yeah this aNull thing was a suggestion by someone previously so that anyone wanting SSL on a unconfigured hostname would "fail fast", but I don't really think it was a big deal either way.

Can you please change this PR to the develop branch?

@jlesage jlesage changed the base branch from master to develop August 21, 2019 00:29
@jlesage
Copy link
Contributor Author

jlesage commented Aug 21, 2019

Yes it was me that initially proposed the aNull change... but it seems that I didn't realized the side effect this was causing.

I changed to PR to develop branch.

@jc21
Copy link
Member

jc21 commented Aug 21, 2019

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-189-amd64

@jc21
Copy link
Member

jc21 commented Aug 21, 2019

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-189-amd64

@jc21 jc21 merged commit 288086c into NginxProxyManager:develop Aug 21, 2019
@jc21
Copy link
Member

jc21 commented Aug 21, 2019

Will create a new versioned release soon, just waiting to hear about another pr

jc21 added a commit that referenced this pull request Sep 4, 2019
* Selection of the ssl protocols/ciphers is done using the default server block. (#189)
* Fix wrap for tags (#195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants