refactor: change Product struct, remove YieldTokenIncidents contract #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
shark0der
reviewed
Dec 11, 2024
shark0der
reviewed
Dec 11, 2024
| @@ -18,7 +18,7 @@ interface IMasterAwareV2 { | |||
| CL, // CoverMigrator.sol - removed | |||
| AS, // Assessment.sol | |||
| CI, // IndividualClaims.sol - Claims for Individuals | |||
| CG, // YieldTokenIncidents.sol - Claims for Groups | |||
| // CG, // YieldTokenIncidents.sol - Claims for Groups | |||
There was a problem hiding this comment.
we cannot comment out stuff from enums - it will change the IDs for the items that follow it. you can rename it to CG_unused, UNUSED_CG or something similar, whatever seems cleaner.
There was a problem hiding this comment.
Good catch, fixed. I will add a unit test for this.
shark0der
reviewed
Dec 11, 2024
shark0der
reviewed
Dec 11, 2024
lib/constants.js
Outdated
| @@ -152,7 +152,7 @@ const ContractCode = { | |||
| StakingProducts: 'SP', | |||
| TokenController: 'TC', | |||
| // TokenData: 'TD', | |||
| YieldTokenIncidents: 'CG', | |||
| // YieldTokenIncidents: 'CG', | |||
There was a problem hiding this comment.
Same here, should we just comment to keep consistency?
There was a problem hiding this comment.
yep, let's keep it consistent
shark0der
reviewed
Dec 11, 2024
shark0der
reviewed
Dec 11, 2024
rackstar
reviewed
Dec 13, 2024
duxxud
changed the base branch from
release-candidate
to
chore/adjust-pricing-parameters
duxxud
force-pushed
the
refactor/remove-yield-token-incidents
branch
from
e2acf6c to
fccbfd9
Compare
duxxud
force-pushed
the
chore/adjust-pricing-parameters
branch
from
4517336 to
7ff6d41
Compare
duxxud
force-pushed
the
refactor/remove-yield-token-incidents
branch
from
bf593b2 to
d92fcff
Compare
rackstar
approved these changes
Dec 18, 2024
Base automatically changed from
chore/adjust-pricing-parameters
to
feat/product-pricing-updates
December 18, 2024 08:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite for #1292
Change the
Productstruct, puttingminPriceinstead ofyieldTokenAddress.Removing the
YieldTokenIncidentscontract.Testing
Adjusted unit and integration tests.
Checklist