feat: add USD price feed support for PriceFeedOracle #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add assets getter natspec comments * convert natspec commets to triple slash
This was referenced Nov 6, 2024
Closed
MilGard91
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1260
These changes adds support for USD-based price feeds to be converted to ETH rate in PriceFeedOracle.
Context:
We want to onboard cbBTC as a new Pool asset but currently cbBTC does not have an ETH price feed only cbBTC-USD priceFeed. These PriceFeedOracle changes are required so that we can onboard cbBTC as a coverAsset.
Testing
Checklist