Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NexusViewer): add assessment stake lockup expiry timestamp in staked NXM #1269

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

mixplore
Copy link
Contributor

@mixplore mixplore commented Oct 21, 2024

Description

FE needs to show the assessment stake lock up expiry date. See convo here https://nexusmutual.slack.com/archives/C04V770JV16/p1729174959771059

Check https://github.com/NexusMutual/frontend-next/pull/1015 for how this is going to be used on FE

Testing

NexusViewer implementation address: 0xB0Bd366F3C58A32A144aF2130F9aC55f30211401
NexusViewer implementation ABI:

 [{"type":"constructor","payable":false,"inputs":[{"type":"address","name":"_master"},{"type":"address","name":"_stakingViewer"},{"type":"address","name":"_assessmentViewer"}]},{"type":"error","name":"RevertedWithoutReason","inputs":[{"type":"uint256","name":"index"}]},{"type":"function","name":"assessmentViewer","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"address"}]},{"type":"function","name":"getClaimableNXM","constant":true,"stateMutability":"view","payable":false,"inputs":[{"type":"address","name":"member"},{"type":"uint256[]","name":"tokenIds"}],"outputs":[{"type":"tuple","components":[{"type":"uint256","name":"governanceRewards"},{"type":"uint256","name":"assessmentRewards"},{"type":"uint256","name":"assessmentStake"},{"type":"uint256","name":"stakingPoolTotalRewards"},{"type":"uint256","name":"stakingPoolTotalExpiredStake"},{"type":"uint256","name":"managerTotalRewards"},{"type":"uint256","name":"legacyPooledStakeRewards"},{"type":"uint256","name":"legacyPooledStakeDeposits"},{"type":"uint256","name":"legacyClaimAssessmentTokens"},{"type":"uint256","name":"legacyCoverNoteDeposits"}]}]},{"type":"function","name":"getStakedNXM","constant":true,"stateMutability":"view","payable":false,"inputs":[{"type":"address","name":"member"},{"type":"uint256[]","name":"tokenIds"}],"outputs":[{"type":"tuple","components":[{"type":"uint256","name":"stakingPoolTotalActiveStake"},{"type":"uint256","name":"assessmentStake"},{"type":"uint256","name":"assessmentStakeLockupExpiry"},{"type":"uint256","name":"assessmentRewards"}]}]},{"type":"function","name":"master","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"address"}]},{"type":"function","name":"multicall","constant":false,"payable":false,"inputs":[{"type":"bytes[]","name":"data"}],"outputs":[{"type":"bytes[]","name":"results"}]},{"type":"function","name":"stakingViewer","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"address"}]}]
  • getStakedNXM call should return assessmentStakeLockupExpiry in the result

Checklist

  • Performed a self-review of my own code
  • Made corresponding changes to the documentation N/A

@mixplore mixplore self-assigned this Oct 21, 2024
@mixplore
Copy link
Contributor Author

😨
image

@shark0der shark0der force-pushed the feat/assessment-stake-lockup-expiry branch from 56a7240 to 1c624c3 Compare October 31, 2024 12:35
@mixplore mixplore force-pushed the feat/assessment-stake-lockup-expiry branch from 1c624c3 to 4391575 Compare December 9, 2024 13:18
@shark0der shark0der force-pushed the feat/assessment-stake-lockup-expiry branch from 4391575 to f71694c Compare January 14, 2025 10:16
@shark0der shark0der merged commit 9b715c0 into release-candidate Jan 14, 2025
6 checks passed
@shark0der shark0der deleted the feat/assessment-stake-lockup-expiry branch January 14, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants