Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metadataIpfsHash to StakingViewer Pool struct #1216

Conversation

rackstar
Copy link
Contributor

Context

Add a new field metadataIpfsHash to StakingViewer Pool struct

Changes proposed in this pull request

  • Add a new field metadataIpfsHash to StakingViewer Pool struct
  • add missing view modifier to StakingProducts.getPoolMetadata
  • small lint fixes (spaces, modifier ordering)

Test plan

  • add unit test

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@rackstar rackstar added the enhancement New feature or request label Aug 21, 2024
@rackstar rackstar self-assigned this Aug 21, 2024
@rackstar rackstar merged commit f818eef into audit/staking-pool-fixes-and-batch-withdrawal Aug 22, 2024
6 checks passed
@rackstar rackstar deleted the feat/add-metadataIpfsHash-to-pool-struct-staking-viewer branch August 22, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants