Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Staking pools' titles and descriptions are stored on ipfs and the contract only emits an event with the ipfs hash. Event fetching takes a looooooooooong time and we want to optimize this.
Changes proposed in this pull request
This PR moves the ipfs hashes from events to storage. The contract choice (
StakingProducts
instead ofStakingPool
) is due to the extremly limited space inStakingPool
.Test plan
Added new unit tests and cleaned up staking pool unit tests.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: