Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Move staking pool metadata #1204

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

shark0der
Copy link
Contributor

@shark0der shark0der commented Aug 6, 2024

Context

Staking pools' titles and descriptions are stored on ipfs and the contract only emits an event with the ipfs hash. Event fetching takes a looooooooooong time and we want to optimize this.

Changes proposed in this pull request

This PR moves the ipfs hashes from events to storage. The contract choice (StakingProducts instead of StakingPool) is due to the extremly limited space in StakingPool.

Test plan

Added new unit tests and cleaned up staking pool unit tests.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@shark0der shark0der changed the title Feat/move staking pool metadata Feat: Move staking pool metadata Aug 7, 2024
@shark0der shark0der linked an issue Aug 7, 2024 that may be closed by this pull request
@shark0der shark0der self-assigned this Aug 7, 2024
@shark0der shark0der marked this pull request as ready for review August 7, 2024 13:07
@roxdanila roxdanila requested a review from MilGard91 August 8, 2024 07:48
@shark0der shark0der force-pushed the fix/reward-shares branch 19 times, most recently from 424186c to 3436fba Compare August 8, 2024 15:53
Copy link
Contributor

@MilGard91 MilGard91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rackstar rackstar marked this pull request as draft August 12, 2024 07:56
@rackstar
Copy link
Contributor

marking as draft so it won't be accidentally merged while on audit

@rackstar rackstar force-pushed the feat/move-staking-pool-metadata branch from 02d2f2c to 0da4532 Compare August 16, 2024 12:37
@rackstar rackstar merged commit 0da4532 into fix/reward-shares Aug 16, 2024
4 checks passed
@rackstar rackstar deleted the feat/move-staking-pool-metadata branch August 16, 2024 12:39
@rackstar rackstar mentioned this pull request Aug 16, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StakingPool: Move pool metadata (i.e. name / description in storage)
3 participants