Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add scripts for proposal simulations #1196

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

MilGard91
Copy link
Contributor

Context

We need a script to simulate and extract tx data for the governance proposal, so we can execute action easier

Changes proposed in this pull request

Add script to simulate and extract tx data for the governance proposal

Test plan

N/A

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 requested a review from rackstar July 24, 2024 06:43
@MilGard91 MilGard91 self-assigned this Jul 24, 2024
@MilGard91 MilGard91 force-pushed the chore/governance-scripts branch from b8ee3be to 806f97a Compare July 24, 2024 07:36
@rackstar
Copy link
Contributor

as discussed, only keep scripts/governance/get-createProposalWithSolution-txdata.js and stash the rest on a branch (in case we need them in the future)

@MilGard91 MilGard91 force-pushed the chore/governance-scripts branch from 806f97a to e9b1a24 Compare July 24, 2024 13:36
@MilGard91 MilGard91 force-pushed the chore/governance-scripts branch from e9b1a24 to adb1d1a Compare July 25, 2024 12:03
@MilGard91 MilGard91 requested a review from rackstar July 25, 2024 12:19
@MilGard91 MilGard91 merged commit 1aec2e3 into release-candidate Jul 25, 2024
6 checks passed
@MilGard91 MilGard91 deleted the chore/governance-scripts branch July 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants