Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement aws kms signer support for deploys #1193

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

shark0der
Copy link
Contributor

@shark0der shark0der commented Jul 22, 2024

Context

Use AWS KMS to deploy contracts.

Changes proposed in this pull request

This PR adds @nexusmutual/ethers-v5-aws-kms-signer as a dep and uses it for the deployer script.

Test plan

Currently it was ran manually to perform a self-tx on mainnet.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@rackstar rackstar changed the title Implement aws kms signer support for deploys feat: Implement aws kms signer support for deploys Jul 22, 2024
@shark0der shark0der marked this pull request as ready for review July 22, 2024 15:09
@shark0der shark0der merged commit a8df423 into release-candidate Jul 22, 2024
6 checks passed
@shark0der shark0der deleted the feat/aws-kms-signer branch July 22, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants