Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover products staking pool fork tests #1191

Conversation

MilGard91
Copy link
Contributor

Context

The fork tests are missing tests for stored values of Staking Pools before and after upgrade

Changes proposed in this pull request

Add tests for staking pools in fork tests

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 linked an issue Jul 22, 2024 that may be closed by this pull request
@MilGard91 MilGard91 force-pushed the test/cover-products-staking-pool-fork-tests branch from 278e82d to 003986a Compare July 22, 2024 10:06
@MilGard91 MilGard91 force-pushed the feature/cover-products-contract-rebased branch from 00a844d to faf90f7 Compare July 23, 2024 13:48
@MilGard91 MilGard91 force-pushed the test/cover-products-staking-pool-fork-tests branch from 003986a to 964e04a Compare July 23, 2024 13:48
@MilGard91 MilGard91 merged commit 964e04a into feature/cover-products-contract-rebased Jul 23, 2024
1 check passed
@MilGard91 MilGard91 deleted the test/cover-products-staking-pool-fork-tests branch July 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StakingPool storage data is not checked in fork tests
2 participants