Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use CoverProducts in listing scripts #1187

Conversation

MilGard91
Copy link
Contributor

Context

Issue: #1131

Changes proposed in this pull request

Change contract used in the script from Cover to CoverProducts

Test plan

Testing on tenderly

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 requested a review from rackstar July 17, 2024 12:02
@MilGard91 MilGard91 linked an issue Jul 17, 2024 that may be closed by this pull request
@MilGard91 MilGard91 force-pushed the feature/cover-products-contract-rebased branch from 00a844d to faf90f7 Compare July 23, 2024 13:48
@MilGard91 MilGard91 force-pushed the feature/cover-products-listing-script branch from 434197f to 16ace53 Compare July 23, 2024 13:58
@MilGard91 MilGard91 force-pushed the feature/cover-products-listing-script branch from 16ace53 to d42ae75 Compare July 23, 2024 14:01
@MilGard91 MilGard91 merged commit d42ae75 into feature/cover-products-contract-rebased Jul 23, 2024
@MilGard91 MilGard91 deleted the feature/cover-products-listing-script branch July 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing scripts should be compatible with the CoverProducts release
2 participants