Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix processExpiration for pool 8 #1149

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Jun 25, 2024

Context

Closes #1151

See the above issue for detailed info

Changes proposed in this pull request

  • Add check in proccessExpirations for pool 8 and rollback lastAccNxmUpdate to prevent underflow

Test plan

  • fork test

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@rackstar rackstar requested a review from shark0der June 25, 2024 12:33
@rackstar rackstar self-assigned this Jun 25, 2024
@rackstar rackstar requested a review from MilGard91 June 25, 2024 12:33
@rackstar rackstar force-pushed the fix/pool-8-staking-pool-bug-fix branch from f561a05 to 02dc7bf Compare June 25, 2024 13:27
@rackstar rackstar changed the title DRAFT: Add StakingPool.rollbackLastAccNxmUpdate fix: Rollback lastAccNxmUpdate to avoid underflow Jun 25, 2024
@rackstar rackstar linked an issue Jun 25, 2024 that may be closed by this pull request
@rackstar rackstar force-pushed the fix/pool-8-staking-pool-bug-fix branch from dba3a6b to 14c8b29 Compare June 25, 2024 14:21
@rackstar rackstar removed the request for review from MilGard91 June 25, 2024 14:26
@rackstar rackstar changed the title fix: Rollback lastAccNxmUpdate to avoid underflow fix: Fix processExpiration for pool 8 Jun 25, 2024
@shark0der shark0der merged commit 2f4745d into release-candidate Jun 26, 2024
6 checks passed
@shark0der shark0der deleted the fix/pool-8-staking-pool-bug-fix branch June 26, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StakingPool lastAccNxmUpdate underflow
3 participants