Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add asset usdc #1112

Merged
merged 5 commits into from
May 31, 2024
Merged

test: add asset usdc #1112

merged 5 commits into from
May 31, 2024

Conversation

MilGard91
Copy link
Contributor

Context

Issue: #1070

Changes proposed in this pull request

Added tests:

  • Proposal for adding USDC as an asset
  • Buying cover with USDC for products that are specific asset before proposal
  • Buying cover for products that are for all assets
  • Swap on cow swap
  • Buy yield token cover with USDC
  • Claim for yield token cover
  • Buy protocal cover with USDC
  • Claim for protocol cover

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 linked an issue May 30, 2024 that may be closed by this pull request
@MilGard91 MilGard91 force-pushed the test/add-asset-usdc branch from 73b4cc2 to 4077fa9 Compare May 30, 2024 07:12
@MilGard91 MilGard91 requested review from roxdanila and rackstar May 30, 2024 07:12
@MilGard91 MilGard91 force-pushed the test/add-asset-usdc branch 2 times, most recently from e2fa998 to 44170df Compare May 30, 2024 07:21
@MilGard91 MilGard91 force-pushed the test/add-asset-usdc branch from 44170df to 6a90d2a Compare May 30, 2024 09:04
@roxdanila roxdanila merged commit 6691c4a into release-candidate May 31, 2024
6 checks passed
@roxdanila roxdanila deleted the test/add-asset-usdc branch May 31, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USDC asset launch: fork tests
3 participants