Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const assertion for generated abis #1062

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

mixplore
Copy link
Contributor

Context

We need const assertion of the abis for Wagmi type safety on FE.
Read more about this here: https://wagmi.sh/core/typescript#const-assert-abis-typed-data

Changes proposed in this pull request

Used the JSON abi files to create the abi const-assert object.

Test plan

Run npm run deployments:build .
Check generated/abis.ts file. It should contain the abis with const assertion.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@mixplore mixplore self-assigned this Feb 15, 2024
@mixplore mixplore requested a review from shark0der February 15, 2024 11:31
@shark0der shark0der changed the base branch from master to release-candidate February 15, 2024 14:07
@shark0der shark0der force-pushed the chore/const-assertion-abis branch 2 times, most recently from 50f3a4a to 2b15027 Compare February 15, 2024 15:59
@shark0der shark0der changed the base branch from release-candidate to master February 15, 2024 16:00
@shark0der shark0der merged commit 1c9001d into master Feb 15, 2024
@shark0der shark0der deleted the chore/const-assertion-abis branch February 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants