Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deps, and modify contracts to support the change #1061

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

MilGard91
Copy link
Contributor

@MilGard91 MilGard91 commented Feb 8, 2024

Context

Issue: #929

Changes proposed in this pull request

  • Remove solmate and @OpenZepelin v2 contracts
    Note: instead of copying the SafeMath.sol to the external directory in the governance, copied it to lib/external since other contracts use that are not in governance directory
    *Note: leaving @openzeppelin/contracts-v4 as it is, if we rename it without the -v4 it breaks the beacon proxy and it's bytecode so the StakingPool addresses are calculated wrong *

Test plan

  • N/A

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 requested a review from shark0der February 8, 2024 16:28
@roxdanila roxdanila linked an issue Feb 14, 2024 that may be closed by this pull request
7 tasks
@MilGard91 MilGard91 force-pushed the chore/remove-old-deps branch 3 times, most recently from b42cca6 to e5d85d2 Compare February 28, 2024 09:06
@MilGard91 MilGard91 marked this pull request as ready for review March 4, 2024 07:57
@MilGard91 MilGard91 force-pushed the chore/remove-old-deps branch from e5d85d2 to 00d2371 Compare March 4, 2024 08:46
@shark0der shark0der force-pushed the chore/remove-old-deps branch 2 times, most recently from 4bc8b97 to a623c0d Compare March 18, 2024 15:54
@roxdanila roxdanila force-pushed the chore/remove-old-deps branch from a623c0d to cea815d Compare March 19, 2024 11:21
@roxdanila roxdanila force-pushed the chore/remove-old-deps branch from cea815d to c45d312 Compare March 20, 2024 10:36
@roxdanila roxdanila merged commit 794892f into release-candidate Mar 20, 2024
6 checks passed
@roxdanila roxdanila deleted the chore/remove-old-deps branch March 20, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove solmate and @openzepplin/contracts v2.5.1 dependencies
3 participants