[feat] data 모듈 생성 및 서버통신 기초 세팅 #11 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyhooon
reviewed
Feb 2, 2025
data/build.gradle.kts
Outdated
| } | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.VERSION_11 |
There was a problem hiding this comment.
여기 Java 17 버전으로 다른 build.gradle 과 통일하게 가면 될듯 합니다.
빌드로직 적용할때 한번에 바꿔도 될것같구
data/src/main/AndroidManifest.xml
Outdated
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
data 모듈이라 manifest 파일을 쓰지 않아서 지우는게 나을것 같네여
| object RetrofitModule { | ||
| @Provides | ||
| fun providesHttpLoggingInterceptor(): HttpLoggingInterceptor = | ||
| HttpLoggingInterceptor().apply { level = HttpLoggingInterceptor.Level.HEADERS } |
There was a problem hiding this comment.
api 통신 로그 Body 까지 다 확인하는게 좋을 것 같아서 Level 을 BODY 로 설정하는게 낫지않을까요?
|
@easyhooon 코드리뷰 반영하였습니다. 확인 부탁드리겠습니다. |
easyhooon
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📁 작업 설명