[simple-app] Drop the preStop default from 30s to 10s #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diranged
force-pushed
the
shorten_prestop
branch
from
7a328c8
to
5d82321
Compare
sabw8217
reviewed
Sep 10, 2021
| # https://docs.flagger.app/tutorials/zero-downtime-deployments#graceful-shutdown | ||
| preStopCommand: | ||
| - /bin/sleep | ||
| - '30' | ||
| - '10' |
There was a problem hiding this comment.
I think it might be worth commenting that the reason we are doing this is to give the pod time to get deregistered from the service.
There was a problem hiding this comment.
I guess the link to the blog post is sufficient
sabw8217
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.