feat: analogous AuthorizationPolicies to NetworkPolicies for (Istio) multi-cluster access #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multi-cluster access
diranged
reviewed
Oct 26, 2024
diranged
reviewed
Oct 28, 2024
diranged
reviewed
Oct 28, 2024
diranged
reviewed
Oct 28, 2024
diranged
reviewed
Oct 28, 2024
diranged
reviewed
Oct 28, 2024
diranged
approved these changes
Oct 28, 2024
schahal
added a commit
that referenced
this pull request
Oct 30, 2024
#344) Ref: #342 ## Motivation We have an `AuthorizationPolicy` where users can set allowedNamespaces. However, it's easy to miss the namespace of the ingress gateway that users may want their VirtualService tied to. ## What This Does This parses the namespace of the istio gateways that users provide and ~creates a new list by appending it to the allowedNamespaces-provided list~ adds a separate rule for it This is a safe assumption due to our checks of its format: https://github.com/Nextdoor/k8s-charts/blob/ca85ca6dedd25eb979e4f3f8240bd53cc424fa45/charts/simple-app/templates/istio/virtualservice.yaml#L19 ## Test Updated set `network.allowAll` and `virtualService.enabled` in values.local.yaml to `true... Resulting relevant diff of `make template`: ### First Commit ```diff --- /tmp/simple-app-orig.yaml 2024-10-29 19:55:03 +++ /tmp/simple-app-new.yaml 2024-10-29 19:57:33 ... @@ -424,7 +424,7 @@ metadata: name: simple-app labels: - helm.sh/chart: simple-app-1.12.1 + helm.sh/chart: simple-app-1.12.2 app.kubernetes.io/version: "latest" app.kubernetes.io/managed-by: Helm tags.datadoghq.com/service: "simple-app" @@ -466,6 +466,7 @@ namespaces: - foo - bar + - istio-gateways to: - operation: ports: ... ``` ### Updated Commit ```diff ... @@ -471,6 +471,15 @@ ports: - "80" - "8443" + - from: + - source: + namespaces: + - "istio-gateways" + to: + - operation: + ports: + - "80" + - "8443" --- ... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this change does
In essence:
AuthorizationPolicythat is analogous to the existingNetworkPolicythat we already create (this should be a no-op)..Values.network.multiCluster.allowFromRemote.Values.network.allowAll, we open up the NetworkPolicy to allow the AuthorizationPolicies above to take over its enforcement wholly.Why
To enable services in a multi-primary (Istio mesh), mult-cluster setup to be accessed from services in a different cluster (because NetworkPolicies can't enforce Ingress from outside the Kubernetes cluster without getting to CIDR ranges - i.e., it only knows about cluster-local namespaces. So, we allow all and instead restrict with Istio's AuthorizationPolicy)