Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itm 228 - validator updates for new api #23

Merged
merged 21 commits into from
May 16, 2024
Merged

Itm 228 - validator updates for new api #23

merged 21 commits into from
May 16, 2024

Conversation

kaitlyn-sharo
Copy link
Contributor

@kaitlyn-sharo kaitlyn-sharo commented Apr 16, 2024

  • No repeated index values in scenes[].
  • All characters need vitals
  • Verify that MOVE_TO_EVAC evac_id is in the state
  • Ensure that none of the action_types in the action_mappings are also in restricted_actions
  • Remove the restriction on setting character.visited
  • Remove the restriction on requiring characters as long as persist_characters is True
  • Update YAML (for, e.g., persist_characters, etc.)
  • Allow all injury statuses.
  • Allow unconscious patients to have avpu of “UNRESPONSIVE” or “PAIN”.
  • Update allowed injury locations in sync with what we support in the simulator
  • Add a flag to say if it's a training (sim) scenario
    • Forbid training-only supplies in eval scenarios (Blanket, Epi Pen, Vented Chest Seal)
  • Added INFO message if there’s no configured final_scene

Copy link
Contributor

@nextcen-dgemoets nextcen-dgemoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good-- and thank you for your patience as these rules change and change again.

I reinstated the "forbidding state in scene 0" rule. Sorry...there was some reason it was there but I can't for the life of me figure out what it was. Plus it requires them creating a dummy state in Scene 0, so....

I had a few comments and a couple of things that didn't work for me. Happy to discuss.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
validator.py Outdated Show resolved Hide resolved
validator.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nextcen-dgemoets nextcen-dgemoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great.
I tweaked the CLI documentation a bit, and allowed training supplies in eval mode as long as the quantity is zero.

Copy link

@dereknop dereknop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enforces all of the rules you described 👍

@kaitlyn-sharo kaitlyn-sharo merged commit 1124f54 into main May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants