Fix admin log pagination after collapsed deletions - #73
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR ensures admin log pagination correctly triggers after deletions collapse the list, by invoking scroll-based load checks immediately after the adapter is updated. Sequence diagram for admin log pagination after deletionssequenceDiagram
participant ChannelAdminLogActivity
participant chatAdapter
participant chatListView
ChannelAdminLogActivity->>chatAdapter: notifyDataSetChanged()
ChannelAdminLogActivity->>chatListView: post(checkScrollForLoad true)
chatListView->>ChannelAdminLogActivity: checkScrollForLoad(true)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief comment near
chatListView.post(() -> checkScrollForLoad(true));to explain that the deferred scroll check is needed to handle pagination correctly after deletions, as this behavior is non-obvious from the code alone. - It may be safer to guard the
chatListView.post(...)call with a null and attachment check (e.g.,chatListView != null && chatListView.isAttachedToWindow()) to avoid posting runnables when the view is no longer active.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief comment near `chatListView.post(() -> checkScrollForLoad(true));` to explain that the deferred scroll check is needed to handle pagination correctly after deletions, as this behavior is non-obvious from the code alone.
- It may be safer to guard the `chatListView.post(...)` call with a null and attachment check (e.g., `chatListView != null && chatListView.isAttachedToWindow()`) to avoid posting runnables when the view is no longer active.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
|
没懂,解决了什么 |
Contributor
Author
操作纪录里超过50条删除记录被折叠后不往下拉拉就不继续加载的问题 |
omg-xtao
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: