Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: Saflok parser Date Rollover #201

Merged
merged 3 commits into from
Sep 3, 2024
Merged

NFC: Saflok parser Date Rollover #201

merged 3 commits into from
Sep 3, 2024

Conversation

Arkwin
Copy link
Contributor

@Arkwin Arkwin commented Sep 2, 2024

Update the saflok parser to properly handle date rollovers.

Saflok plugin date rollover

  • The Saflok parser now handles dates rolling over properly. For example, a car programmed with a creation date of 8/31/2024 and an interval of 2 days would say 8/33/2024 instead of 9/02/2024. This is now been corrected to properly display expiring dates.

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Update the saflok parser to properly handle date rollovers.
@Willy-JL Willy-JL added the bugfix Something isn't working label Sep 3, 2024
@Willy-JL Willy-JL changed the title Date Rollover NFC: Saflok parser Date Rollover Sep 3, 2024
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Willy-JL Willy-JL merged commit 67ffec5 into Next-Flip:dev Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants