[fix] Fixed matchRegexp validation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, @mrazicz |
Contributor
Author
|
Hi, match Regexp does not work at all.
Internally you split that validator by ":" and then you pass "^[0-9]{8}$" directly to matchRegexp function as String. But string doesn't have method test() so it fails. Eslint - sure. I'm kind of new to React and javascript, so I don't know about these features :) |
Contributor
Author
|
Here it is. Eslint output is empty now :) |
Owner
|
All fine, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just ran into issue with matchRegexp validation. So I fixed it, and here is a pull request. Hope you will like it and will be merged into master.