feat: set default HTTP request timeout to 150 seconds #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default timeout for all HTTP requests from the previous conditional values (60s for GET, 120s for other methods) to a consistent 150 seconds across all HTTP methods.
Changes Made
Modified
ddns/util/http.py
:timeout=150
for all HTTP requests instead of the previous conditional logicAdded test coverage in
tests/test_util_http.py
:TestHttpRequestTimeout
class with comprehensive test to verify the 150-second timeoutImpact
Testing
Fixes #554.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.