Skip to content

Commit

Permalink
Bluetooth: Remove pointless parameter check in hci_uart_send_frame()
Browse files Browse the repository at this point in the history
The hdev parameter of hci_uart_send_frame() is always valid. If it
were not valid, then it would have crashed earlier in the call chain.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
  • Loading branch information
holtmann authored and Johan Hedberg committed Oct 11, 2013
1 parent 03b3186 commit 52bc423
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions drivers/bluetooth/hci_ldisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,18 +236,11 @@ static int hci_uart_close(struct hci_dev *hdev)
/* Send frames from HCI layer */
static int hci_uart_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
{
struct hci_uart *hu;

if (!hdev) {
BT_ERR("Frame for unknown device (hdev=NULL)");
return -ENODEV;
}
struct hci_uart *hu = hci_get_drvdata(hdev);

if (!test_bit(HCI_RUNNING, &hdev->flags))
return -EBUSY;

hu = hci_get_drvdata(hdev);

BT_DBG("%s: type %d len %d", hdev->name, bt_cb(skb)->pkt_type, skb->len);

hu->proto->enqueue(hu, skb);
Expand Down

0 comments on commit 52bc423

Please sign in to comment.