Skip to content
This repository has been archived by the owner on Aug 25, 2020. It is now read-only.

Adding debounce to validate field when fieldChanged is called #31

Merged
merged 3 commits into from
Jan 16, 2019

Conversation

Nevoss
Copy link
Owner

@Nevoss Nevoss commented Jan 11, 2019

now if using fieldChanged method and the option to validate on fieldChanged is on, there is an additional option the let the user chose a debounce time to the validation of the field. (by default the debounce time is 0)

related to #29

now if using `fieldChanged` method and the option to validate on field changed is on, there is an additional option the let the user chose a debounce time to the validation of the field. (by default the debounce time is 0)
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #31 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev      #31      +/-   ##
=========================================
+ Coverage   99.6%   99.62%   +0.01%     
=========================================
  Files         13       14       +1     
  Lines        253      264      +11     
  Branches      42       41       -1     
=========================================
+ Hits         252      263      +11     
  Misses         1        1
Impacted Files Coverage Δ
src/default-options.ts 100% <ø> (ø) ⬆️
src/utils.ts 100% <100%> (ø) ⬆️
src/core/Form.ts 99.19% <100%> (+0.01%) ⬆️
src/helpers/generateDebouncedValidateField.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5b44c...d1e42f8. Read the comment docs.

adding debouncedValidateFieldTime to the option section
@Nevoss Nevoss merged commit ab42936 into dev Jan 16, 2019
@Nevoss Nevoss deleted the feature/debouce-validation-on-field-changed branch January 16, 2019 11:56
Nevoss added a commit that referenced this pull request Jan 19, 2019
* Adding debounce to validate field when `fieldChanged` is called

now if using `fieldChanged` method and the option to validate onField changed is on, there is an additional option the let the user chose a debounce time to the validation of the field. (by default the debounce time is 0)

* Changing the name of the `debouncedTime` option

* Updating README.md

adding debouncedValidateFieldTime to the option section
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant